[IMP] impersonate_login: Restrict Admin settings impersonation #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Kev-Roche, |
toita86
force-pushed
the
14.0-IMP-impersonate_login-toita86
branch
2 times, most recently
from
d9415df to
6739552
Compare
|
@Kev-Roche what do you think? we don't want users to install modules while impersonating other users, but it can be made more generic/extendable if you wish. |
|
It is a good idea ! As you add a new feature, a short test will be nice. |
toita86
force-pushed
the
14.0-IMP-impersonate_login-toita86
branch
from
6739552 to
a028010
Compare
toita86
force-pushed
the
14.0-IMP-impersonate_login-toita86
branch
from
a028010 to
5895660
Compare
|
@Kev-Roche tests added, if you have any concerns or suggestions for improvement, please let me know. |
|
@Kev-Roche can you please merge? |
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at a2997f5. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a configuration setting (
restrict_impersonate_admin_settings) to exclude users with "Administration: Settings" rights to be impersonated. When enabled, only non-administrative users can be impersonated.